Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec-stewards #85

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Update spec-stewards #85

merged 2 commits into from
Nov 21, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 21, 2022

Summary

  • Removes folks who are not directly involved in IPFS/specs
  • Adds @darobin who is leading Governance & Standards @protocol

Why do you need this?

See ipfs/specs#291

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@lidel lidel requested review from a team as code owners November 21, 2022 14:45
@lidel lidel requested a review from galargh November 21, 2022 14:45
@github-actions
Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
  - destroy
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # github_repository_file.this["ecosystem-directory/.github/workflows/stale.yml"] must be replaced
-/+ resource "github_repository_file" "this" {
      ~ branch              = "develop" -> "main" # forces replacement
      ~ commit_author       = "GitHub" -> (known after apply)
      ~ commit_email        = "noreply@github.com" -> (known after apply)
      ~ commit_sha          = "d40c860f07414168f691f9b5ee427867c3d49d87" -> (known after apply)
      ~ id                  = "ecosystem-directory/.github/workflows/stale.yml" -> (known after apply)
      ~ sha                 = "6f6d895d19361a0219079a97d8eb216f5d9e66a1" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # github_team_membership.this["Specs Stewards:Stebalien"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "6237620:Stebalien"
      ~ role     = "maintainer" -> "member"
        # (3 unchanged attributes hidden)
    }

  # github_team_membership.this["Specs Stewards:darobin"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = "6237620"
      + username = "darobin"
    }

  # github_team_membership.this["Specs Stewards:marten-seemann"] will be destroyed
  # (because key ["Specs Stewards:marten-seemann"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"2b7606b21e6b1e565fff524146e9cc0efec71a4f3e994a3d61641d6fab583a94\"" -> null
      - id       = "6237620:marten-seemann" -> null
      - role     = "member" -> null
      - team_id  = "6237620" -> null
      - username = "marten-seemann" -> null
    }

  # github_team_membership.this["Specs Stewards:petar"] will be destroyed
  # (because key ["Specs Stewards:petar"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"aecfaa987e98c698e67f87a554cec1a0e457fffa563968f6f32a9101c91d4dd7\"" -> null
      - id       = "6237620:petar" -> null
      - role     = "member" -> null
      - team_id  = "6237620" -> null
      - username = "petar" -> null
    }

Plan: 2 to add, 1 to change, 3 to destroy.

@lidel lidel merged commit 9e3e3c7 into master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants